Skip to content

Allow peer to use beta2 of datasource-juggler (and future) - #349

Merged
bajtos merged 1 commit into
strongloop:2.0from
lchenay:patch-2
Jun 26, 2014
Merged

Allow peer to use beta2 of datasource-juggler (and future)#349
bajtos merged 1 commit into
strongloop:2.0from
lchenay:patch-2

Conversation

@lchenay

@lchenay lchenay commented Jun 25, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@slnode

slnode commented Jun 25, 2014

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@bajtos

bajtos commented Jun 25, 2014

Copy link
Copy Markdown
Member

@slnode ok to test

@bajtos

bajtos commented Jun 25, 2014

Copy link
Copy Markdown
Member

Hi @lchenay, thank you for the pull request. We did not realize ~ works with pre-release versions, that's nice!

Could you please modify other 2.0 dependencies too? I mean strong-remoting in dependencies, and loopback-datasource-juggler in devDependencies.

To get your patch accepted, we need you to sign the CLA per our Contributing guide.

Note: don't send a new pull request with the fixes, use git commit --amend and git push -f to modify the patch in this pull request.

Signed-off-by: Laurent Chenay <lchenay@gmail.com>
bajtos added a commit that referenced this pull request Jun 26, 2014
Allow peer to use beta2 of datasource-juggler (and future)
@bajtos
bajtos merged commit 1daa93e into strongloop:2.0 Jun 26, 2014
@bajtos

bajtos commented Jun 26, 2014

Copy link
Copy Markdown
Member

Landed, thank you!

@slnode

slnode commented Jun 26, 2014

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants